Disallow owner from claiming protocol fees #474
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hensha256
previously approved these changes
Feb 12, 2024
Co-authored-by: saucepoint <[email protected]>
* default to evm_version cancun for 0.8.24 for tstore; remove custom solc binaries; remove justfile * snapshots * remove custom solc from CI * remove additional custom solc references * restore formatting
hensha256
approved these changes
Feb 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Closes #449
Description of changes
Currently on main we allow either the owner of PoolManager or the currently set protocol fee controller to call
collectProtocolFees. We haven't found a compelling use case for special casing the owner here so removing it for now.