feat: hooks refactor POC #411
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The per-hook block is increasing in size over time and now is roughly 8 lines of code duplicated 8 times after #404 and #324. This commit attempts to refactor some of this copied logic into the Hooks library to improve readability of the core PoolManager code while also removing duplicated code This is a proof of concept, I'll wait until the above PRs are merged to include them in this model and can improve testing a lot with this new approach as well
|
oof gas quite a bit worse due to extra jumps, will think about how to improve that |
marktoda
commented
Nov 17, 2023
| function validateHooksResponse(bytes4 selector, bytes4 expectedSelector) internal pure { | ||
| if (selector != expectedSelector) { | ||
| revert InvalidHookResponse(); | ||
| } |
There was a problem hiding this comment.
to add: noop handling here
There was a problem hiding this comment.
this refactor will be strange with NoOp because we have to run the clear currentHook logic before returning
marktoda
commented
Nov 17, 2023
| IPoolManager.ModifyPositionParams memory params, | ||
| bytes memory hookData | ||
| ) internal { | ||
| if (!key.hooks.shouldCall(BEFORE_MODIFY_POSITION_FLAG)) return; |
There was a problem hiding this comment.
to add: CA handling
Closed
|
One comment.. if we can find a nice way to use a helper for the callsite calls, I think it would be neater to do the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The per-hook block is increasing in size over time and now is roughly
8 lines of code duplicated 8 times after #404 and #324. This commit
attempts to refactor some of this copied logic into the Hooks library
to improve readability of the core PoolManager code while also
removing duplicated code
This is a proof of concept, I'll wait until the above PRs are merged to
include them in this model and can improve testing a lot with this new
approach as well
Related Issue
Which issue does this pull request resolve?
Description of changes