New locker lib: unpacks length and nonzeroDeltaCount #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhongeric
reviewed
Nov 7, 2023
| uint256 slot = NONZERO_DELTA_COUNT; | ||
| assembly { | ||
| let count := tload(slot) | ||
| count := sub(count, 1) |
There was a problem hiding this comment.
Do you think its worth catching the underflow here?
There was a problem hiding this comment.
No because we only call this if we've incremented prior so I think its ok and its an internal function
hensha256
reviewed
Nov 8, 2023
|
|
||
| /// @notice This is a temporary library that allows us to use transient storage (tstore/tload) | ||
| /// for the lockers array and nonzero delta count. | ||
| library Lockers { |
There was a problem hiding this comment.
Would be great to see some tests for this library!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
Description of changes