Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support arbitrary bytes on test routers #343

Closed
wants to merge 22 commits into from
Closed

Support arbitrary bytes on test routers #343

wants to merge 22 commits into from

Commits on Aug 25, 2023

  1. overload PoolSwapTest.swap() with support for arbitrary bytes

    @saucepoint
    saucepoint committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    968c345 View commit details
    Browse the repository at this point in the history

  2. forge fmt

    @saucepoint
    saucepoint committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    870b588 View commit details
    Browse the repository at this point in the history

  3. consolidate logic to one function

    @saucepoint
    saucepoint committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    8e65fdf View commit details
    Browse the repository at this point in the history

  4. overload routertest.modifyPosition() with support for arbitrary bytes

    @saucepoint
    saucepoint committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    bb5ae64 View commit details
    Browse the repository at this point in the history

  5. overload PoolDonateTest.donate() with support for arbitrary bytes

    @saucepoint
    saucepoint committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    c304834 View commit details
    Browse the repository at this point in the history

  6. overload test helper with support for arbitrary bytes

    @saucepoint
    saucepoint committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    b45318b View commit details
    Browse the repository at this point in the history

  7. define storage variables to verify arbitrary calldata

    @saucepoint
    saucepoint committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    bb48e13 View commit details
    Browse the repository at this point in the history

  8. test that arbitrary calldata provided through routers are being captu… 

    …red in the hook
    @saucepoint
    saucepoint committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    1d53214 View commit details
    Browse the repository at this point in the history

  9. forge fmt

    @saucepoint
    saucepoint committed Aug 25, 2023
    Configuration menu
    Copy the full SHA
    9a67aaa View commit details
    Browse the repository at this point in the history

Commits on Sep 8, 2023

  1. resolve conflicts

    @saucepoint
    saucepoint committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    8c65e81 View commit details
    Browse the repository at this point in the history

  2. forge snapshots

    @saucepoint
    saucepoint committed Sep 8, 2023
    Configuration menu
    Copy the full SHA
    1347893 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Merge branch 'main' into router-bytes

    @saucepoint
    saucepoint committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    f3623dc View commit details
    Browse the repository at this point in the history

  2. remove overloaded modifyPosition(); consolidate PoolModifyPositionTes… 

    …t.modifyPosition()
    @saucepoint
    saucepoint committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    e04f2c2 View commit details
    Browse the repository at this point in the history

  3. remove overloaded swapRouter.swap() and consolidate to signature with… 

    … bytes memory
    @saucepoint
    saucepoint committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    9f08118 View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2023

  1. Merge pull request #1 from saucepoint/consolidate 

    Consolidate overloaded `modifyPosition` and `swap`
    @saucepoint
    saucepoint authored Sep 19, 2023
    Configuration menu
    Copy the full SHA
    1346029 View commit details
    Browse the repository at this point in the history

  2. updated hardhart tests with the new router function signatures; updat… 

    …ed hardhat gas snapshots
    @saucepoint
    saucepoint committed Sep 19, 2023
    Configuration menu
    Copy the full SHA
    fdef1fa View commit details
    Browse the repository at this point in the history

Commits on Sep 21, 2023

  1. function visibility

    @saucepoint
    saucepoint committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    298e7bb View commit details
    Browse the repository at this point in the history

  2. remove overloaded PoolDonateTest.donate(), updated tests with new fun… 

    …ction signature
    @saucepoint
    saucepoint committed Sep 21, 2023
    Configuration menu
    Copy the full SHA
    8b66c7b View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2023

  1. provide empty bytes on donate; yarn prettier

    @saucepoint
    saucepoint committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    40122d5 View commit details
    Browse the repository at this point in the history

  2. recalc gas snapshots

    @saucepoint
    saucepoint committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    079693d View commit details
    Browse the repository at this point in the history

  3. misc

    @saucepoint
    saucepoint committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    ba7bdd7 View commit details
    Browse the repository at this point in the history

  4. forge fmt

    @saucepoint
    saucepoint committed Sep 26, 2023
    Configuration menu
    Copy the full SHA
    9d8ce09 View commit details
    Browse the repository at this point in the history