Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move MockERC20.sol to contracts/test #335

Closed
wants to merge 2 commits into from
Closed

Conversation

emmaguo13
Copy link
Contributor

Description of changes

MockERC20 should be used instead of TestERC20 in some cases, as it exposes more functions/external values for tests to use.

@emmaguo13 emmaguo13 marked this pull request as ready for review August 10, 2023 19:29
@emmaguo13 emmaguo13 requested a review from ewilz August 10, 2023 19:29
@emmaguo13
Copy link
Contributor Author

I did have to change the solmate remappings in remappings.txt, otherwise it would not work with hardhat 😐, and I wasn't able to yarn install a specific commit hash, so I went 1 version above the version installed in forge lib.

@marktoda marktoda closed this Nov 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants