add snapshot to CI #331
Closed
add snapshot to CI #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
snreynolds
force-pushed
the
snapshots
branch
from
4c79e3a to
cdcc6a6
Compare
|
trying to fix #216 |
2 tasks
[FAIL. Reason: The `vm.assume` cheatcode rejected too many inputs (65536 allowed)] testHookWithdrawFeeProtocolWithdrawFee(uint16,uint16) (runs: 5904, μ: 533782, ~: 538058) TODO: fix above error
|
tl;dr had to set the fuzz seed in the environment because forge snapshot does not respect it from foundry.toml currently (issue below). So now we should use the Reference to foundry issue foundry-rs/foundry#6179 |
snreynolds
commented
Oct 31, 2023
|
closing this in favor of this #401 just squashes these, rebases main, and adds a tolerance |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
We should be running forge snapshots on all PRs locally & on CI. There was an issue with getting the fuzz snapshots locally to match the CI. Hopefully we can resolve it in this PR.
Description of changes