Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate SqrtPriceMath tests from HardHat to Foundry #317

Merged
merged 15 commits into from
Jul 31, 2023
Merged

Migrate SqrtPriceMath tests from HardHat to Foundry #317

merged 15 commits into from
Jul 31, 2023

Commits on Jul 25, 2023

  1. foundry-test: Refactor constants to a library. 

    The constants library will allow to directly access constants from
multiple Foundry tests.

Ref: Uniswap#315
    @gitcoindev
    gitcoindev committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    4ff1283 View commit details
    Browse the repository at this point in the history

  2. foundry-test: Migrate SqrtPriceMath#getNextSqrtPriceFromInput to 

    Foundry.

Ref: Uniswap#315
    @gitcoindev
    gitcoindev committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    1cc5abd View commit details
    Browse the repository at this point in the history

  3. foundry-test: Move MAX_UINT128 and MAX_UINT256 to Constants. 

    Ref: Uniswap#315
    @gitcoindev
    gitcoindev committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    d8678d3 View commit details
    Browse the repository at this point in the history

  4. foundry-test: Migrate SqrtPriceMath#getNextSqrtPriceFromOutput to Fou… 

    …ndry.

Ref: Uniswap#315
    @gitcoindev
    gitcoindev committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    488137a View commit details
    Browse the repository at this point in the history

  5. foundry-test: Migrate SqrtPriceMath#getAmount0Delta to Foundry. 

    Ref: Uniswap#315
    @gitcoindev
    gitcoindev committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    83e3f25 View commit details
    Browse the repository at this point in the history

  6. foundry-test: Migrate SqrtPriceMath#getAmount1Delta to Foundry. 

    Ref: Uniswap#315
    @gitcoindev
    gitcoindev committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    64e147c View commit details
    Browse the repository at this point in the history

  7. foundry-test: Migrate SqrtPriceMath#swapComputation to Foundry. 

    Ref: Uniswap#315
    @gitcoindev
    gitcoindev committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    3b44c34 View commit details
    Browse the repository at this point in the history

  8. test: Remove migrated SqrtPriceMath from HardHat to Foundry. 

    Ref: Uniswap#315
    @gitcoindev
    gitcoindev committed Jul 25, 2023
    Configuration menu
    Copy the full SHA
    3e2eb6e View commit details
    Browse the repository at this point in the history

Commits on Jul 28, 2023

  1. test: SqrtPriceMath: Use forge-gas-snapshot, delete expandTo18Decimal… 

    …s and JS references.

Refactor after PR review findings.
    @gitcoindev
    gitcoindev committed Jul 28, 2023
    Configuration menu
    Copy the full SHA
    eed97dd View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2023

  1. test: Add and use MAX_UINT160 constant in SqrtPriceMath.

    @gitcoindev
    gitcoindev committed Jul 30, 2023
    Configuration menu
    Copy the full SHA
    7aa0ac5 View commit details
    Browse the repository at this point in the history

Commits on Jul 31, 2023

  1. test: Remove unnecessary comments from SqrtPriceMath. 

    Ref: Uniswap#315
    @gitcoindev
    gitcoindev committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    d1d5b5e View commit details
    Browse the repository at this point in the history

  2. test: Update SqrtPriceMath gas snapshots after migration from Hardhat to 

    Forge.

Ref: Uniswap#315
    @gitcoindev
    gitcoindev committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    a72796e View commit details
    Browse the repository at this point in the history

  3. test: Update correct SqrtPriceMath gas snapshot for 

    getNextSqrtPriceFromInput_zeroForOneEqualsFalseGas.
    @gitcoindev
    gitcoindev committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    c56e765 View commit details
    Browse the repository at this point in the history

  4. test: SqrtPriceMath: Call library directly instead of test contract. 

    The test contract was a middle layer between library and was used by
javascript / HardHat tests. Due to the middle layer using Foundry,
gas cost usage was calculated incorrectly.

Generate correct gas snapshots using direct library calls.

Ref: Uniswap#315
    @gitcoindev
    gitcoindev committed Jul 31, 2023
    Configuration menu
    Copy the full SHA
    9ca00b0 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'main' into feature/migrate_SqrtPriceMath

    @ewilz
    ewilz authored Jul 31, 2023
    Configuration menu
    Copy the full SHA
    3fd8a91 View commit details
    Browse the repository at this point in the history