Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement protocol fees for NoOps #308

Closed
wants to merge 10 commits into from
Closed

Implement protocol fees for NoOps #308

wants to merge 10 commits into from

Conversation

emmaguo13
Copy link
Contributor

No description provided.

ewilz
ewilz reviewed Jul 13, 2023
View reviewed changes
contracts/PoolManager.sol Outdated Show resolved Hide resolved
@emmaguo13
Copy link
Contributor Author

might move the fee logic to a function in Pool.sol, but for now, keeping in PoolManager (makes manager code a bit clunky unfortunately)

@snreynolds
Copy link
Member

Closing in favor of this noop impl #324

@snreynolds snreynolds closed this Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewilz ewilz ewilz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmaguo13 @snreynolds @ewilz