revert: forge snapshot --check in ci #215
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 3a9d4b8.
snreynolds
force-pushed
the
try-revert-snapshot
branch
from
cd0c057 to
1f61c50
Compare
|
should this remove the snapshot file for now? |
|
Could be wrong, but it seems like there's some valid changes in some of the past commits. Plus a snapshot got added but it doesn't actually exist in that test. I think we just want to get rid of the workflow and and just name PR something like |
ewilz
approved these changes
Jun 13, 2023
hensha256
reviewed
Jun 13, 2023
hensha256
approved these changes
Jun 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issue
Which issue does this pull request resolve?
Ongoing issue with local snapshots and ci run snapshots. Need to create a better/more sustainable workflow to make sure they are run on every PR but also make sure they are run deterministically with fuzz tests.
Description of changes