Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme update #195

Merged
merged 5 commits into from
Jun 8, 2023
Merged

readme update #195

merged 5 commits into from
Jun 8, 2023

Conversation

snreynolds
Copy link
Member

No description provided.

marktoda
marktoda approved these changes Jun 8, 2023
View reviewed changes
README.md
- `donate`
- `take`
- `settle`
- `mint`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

burn?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

er i guess burn doesnt require lock technically but kinda dumb to do it outside of lock no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the way you burn is actually by calling
safeTransferFrom on the ERC1155 token into the pool manager. This calls onERC1155Received, which burns and accounts the delta

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But actually I'm wondering if we do need to put that under the lock... it feels odd that we could start accounting deltas when the contact isnt locked. That sounds like a bug no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update: sara and i think it would revert when it hits accountDelta because there would be no lockers - so lockedBy.length-1 underflows. But we should check

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, think we should test the case where its called without a lock.

hensha256
hensha256 reviewed Jun 8, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
hensha256
hensha256 reviewed Jun 8, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
hensha256
hensha256 reviewed Jun 8, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
hensha256
hensha256 reviewed Jun 8, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
hensha256
hensha256 reviewed Jun 8, 2023
View reviewed changes
README.md

## License

The primary license for Uniswap V4 Core is the Business Source License 1.1 (`BUSL-1.1`), see [LICENSE](https://github.com/Uniswap/core-next/blob/main/LICENSE)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Has legal approved this wording?
"Primary" to me implies there are multiple licenses

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So there will be GPL for the interfaces and some libraries. I pulled the wording from v3 and I can send to Ian to check :)

snreynolds and others added 4 commits June 8, 2023 11:30
@snreynolds @hensha256
Update README.md
57bbb50 
Co-authored-by: Alice <[email protected]>
@snreynolds @hensha256
Update README.md
6502733 
Co-authored-by: Alice <[email protected]>
@snreynolds @hensha256
Update README.md
34dfcf4 
Co-authored-by: Alice <[email protected]>
@snreynolds @hensha256
Update README.md
a4dd7f4 
Co-authored-by: Alice <[email protected]>
@snreynolds snreynolds merged commit d797d8d into main Jun 8, 2023
@snreynolds snreynolds deleted the readme branch June 8, 2023 11:44
aadams added a commit that referenced this pull request Jun 9, 2023
@aadams
Squashed commit of the following:
fabf6c1 
commit b4dec0b
Author: Emily Williams <[email protected]>
Date:   Thu Jun 8 19:53:42 2023 -0400

    extsload interface as view function (#201)

commit ebff901
Author: Alice <[email protected]>
Date:   Thu Jun 8 20:55:25 2023 +0100

    Fix tree and example in readme (#198)

    * Fix tree and example in readme

    * Update README.md

commit 7e940f8
Author: guoemma13 <[email protected]>
Date:   Thu Jun 8 13:28:10 2023 -0400

    migrate init and mint tests (#185)

    * tests in progress

    * initialize and mint tests

    * tests cleanup

    * checks are passing

    * delete hardhat tests

    * fix comments

    * failing tests with negative tick

    * all working swap tests

    * check swap tests

    * run formatter

    * remove hardhat tests

    * failing with EmptyTestHooks

    * simplified MockHooksSimple

    * separate tests

    * update gas snapshot tests

    * failing with testhooksimpl

    * finish tests

    * cleanup

    * fix error

    ---------

    Co-authored-by: Emma Guo <[email protected]>
    Co-authored-by: emmaguo13 <[email protected]>
    Co-authored-by: emmaguo13 <[email protected]>
    Co-authored-by: emma <[email protected]>

commit e46262c
Author: Emily Williams <[email protected]>
Date:   Thu Jun 8 11:20:14 2023 -0400

    extsload (#199)

    * extsload with tests
    * consistent number formatting in assembly

commit ae7a8e1
Author: Sara Reynolds <[email protected]>
Date:   Thu Jun 8 13:41:21 2023 +0000

    pr template (#196)

    Co-authored-by: Alice <[email protected]>

commit d797d8d
Author: Sara Reynolds <[email protected]>
Date:   Thu Jun 8 11:44:29 2023 +0000

    readme update (#195)

    Co-authored-by: Alice <[email protected]>

commit 4e161fa
Author: Noah Zinsmeister <[email protected]>
Date:   Thu Jun 8 06:24:10 2023 -0400

    make BalanceDelta a type (#180)

    * add type

    * add type to impl

    fix tests

    update snapshots

    * create new toInt128

commit 93ab363
Author: Sara Reynolds <[email protected]>
Date:   Thu Jun 8 01:26:18 2023 +0000

    add contribution guidelines (#194)

commit 2279064
Author: Sara Reynolds <[email protected]>
Date:   Wed Jun 7 23:48:16 2023 +0000

    fix: feature template (#193)

commit 6264ed3
Author: Sara Reynolds <[email protected]>
Date:   Wed Jun 7 22:49:42 2023 +0000

    Revert "fix feature template"

    This reverts commit 479a00a.

commit 479a00a
Author: Sara Reynolds <[email protected]>
Date:   Wed Jun 7 22:48:43 2023 +0000

    fix feature template

commit 85b16d3
Author: Sara Reynolds <[email protected]>
Date:   Wed Jun 7 22:40:30 2023 +0000

    Update FEATURE_IMPROVEMENT.yml

commit 283409f
Author: Sara Reynolds <[email protected]>
Date:   Wed Jun 7 22:36:11 2023 +0000

    add feature improvement template (#192)

commit 469a87c
Author: Sara Reynolds <[email protected]>
Date:   Wed Jun 7 21:06:57 2023 +0000

    Add bug report template (#191)

    Co-authored-by: Alice <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hensha256 hensha256 hensha256 approved these changes

@marktoda marktoda marktoda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@snreynolds @hensha256 @marktoda