Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

change permit2 gh url #296

Merged
merged 1 commit into from
May 24, 2023
Merged

change permit2 gh url #296

merged 1 commit into from
May 24, 2023

Conversation

restlessronin
Copy link

@restlessronin restlessronin commented May 19, 2023 •
edited
Loading

@hensha256 I could not link the permit2 submodule until I made this change. I then had to git submodule deinit lib/permit2 followed by git submodule init/

@shuhuiluo
Copy link
Contributor

Closes #246.

@hensha256
Copy link
Collaborator

Thanks for doing this! CI will fail due to this being a fork PR - so our process is that we have to merge this into a local branch and make a new PR into main so we can allow CI to run in full. I'll sort that now!

@hensha256 hensha256 changed the base branch from main to fix-permit2-submodule May 24, 2023 10:05
@hensha256 hensha256 merged commit 9a67d14 into Uniswap:fix-permit2-submodule May 24, 2023
@hensha256 hensha256 mentioned this pull request May 24, 2023
Open
@restlessronin restlessronin deleted the fix-permit2-submodule branch May 24, 2023 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hensha256 hensha256 hensha256 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@restlessronin @shuhuiluo @hensha256