increase length limit for token list name #136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zzmp
approved these changes
Jun 7, 2022
|
Vào 21:53, T.3, 7 Th6, 2022 Zach Pomerantz ***@***.***> đã
viết:
… ***@***.**** approved this pull request.
Please update the PR description (or eventual commit message) to explain
that there is still a restrictive limit to combat spoofing (ie
right-padding with ).
—
Reply to this email directly, view it on GitHub
<#136 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AT4XRBE4L2EEJJPAFBUC3NTVN5O7RANCNFSM5YA2A4HA>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
|
18 |
|
Approval request completed........On Aug 8, 2023 3:57 AM, Utpal Banerjee ***@***.***> wrote:
@alokeutpal approved this pull request.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Increasing length limit of token list names from 20 to 30 to allow for longer names. We are not completely removing the limit in order to prevent spoofing, such as right-padding with whitespace.