Add full SOR support for MixedRoutes #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t string encodings
…all-with-quoter-v3-abi
willpote
reviewed
Aug 10, 2022
snreynolds
reviewed
Aug 10, 2022
willpote
approved these changes
Aug 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Main areas of concern:
getMixedRouteCandidatePools()inget-candidate-pools.ts, especially the logic for the heuristic implementation.V3QuoteProvidertoOnChainQuoteProvider, as well as introducing the generic type used to create instances of the class.MixedRouteQuoteProviderfor mainnet + eth testnets)Note: package-lock should not change besides the resolved versions of
ethersandethersproject/providersbeing ^5.6.1 and ^5.4.0, respectively. I think current diff is from installing a local tarball of router-sdk, but will fix before merging.