Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: rename WrappedTokenInfo class #7495

Merged
merged 7 commits into from
Nov 6, 2023
Merged

fix: rename WrappedTokenInfo class #7495

merged 7 commits into from
Nov 6, 2023

Conversation

kristiehuang
Copy link
Contributor

@kristiehuang kristiehuang commented Oct 18, 2023 •
edited
Loading

Misleading class name, thought it was for WETH/WBTC/etc. Proposing a rename to TokenFromList?

Also replace use of this class for Gql token queries- we have an existing gqlToCurrency function for this.

@vercel
Copy link

vercel bot commented Oct 18, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
interface ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 19, 2023 6:44pm

@kristiehuang kristiehuang marked this pull request as ready for review October 18, 2023 22:34
@kristiehuang kristiehuang requested review from a team and tinaszheng October 18, 2023 22:34
@codecov
Copy link

codecov bot commented Oct 18, 2023 •
edited
Loading

Codecov Report

Merging #7495 (9976170) into main (819e2f5) will increase coverage by 0.01%.
Report is 29 commits behind head on main.
The diff coverage is 72.72%.

Flag Coverage Δ
cloud-tests 83.60% <ø> (ø)
unit-tests 42.76% <72.72%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

@cypress
Copy link

cypress bot commented Oct 18, 2023 •
edited
Loading

Passing run #15151 ↗︎

0 122 0 0 Flakiness 0

Details:

fix: rename WrappedTokenInfo class
Project: Uniswap Interface Commit: 9976170d33
Status: Passed Duration: 15:37 💡
Started: Oct 19, 2023 8:12 PM Ended: Oct 19, 2023 8:27 PM

Review all test suite changes for PR #7495 ↗︎

@kristiehuang kristiehuang requested review from cartcrom and zzmp October 19, 2023 18:42
@kristiehuang kristiehuang merged commit 769a7ab into main Nov 6, 2023
21 checks passed
@kristiehuang kristiehuang deleted the fix-wrapped-token-info-classname branch November 6, 2023 21:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cartcrom cartcrom cartcrom approved these changes

@mattbspector mattbspector mattbspector approved these changes

@tinaszheng tinaszheng Awaiting requested review from tinaszheng

@zzmp zzmp Awaiting requested review from zzmp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kristiehuang @mattbspector @cartcrom