feat: better error page #5536
Merged
feat: better error page #5536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Deploying with
|
| Latest commit: |
54b8ec4
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://edab4cdc.interface-y3o.pages.dev |
| Branch Preview URL: | https://feat-error-page.interface-y3o.pages.dev |
|
Sentry temporarily pinned down to an older version till getsentry/sentry-javascript#6392 is released (results in an eventId being 0000000) |
grabbou
commented
Dec 5, 2022
grabbou
commented
Dec 5, 2022
grabbou
commented
Dec 5, 2022
| @@ -90,19 +90,19 @@ export default function UnstakingModal({ isOpen, onDismiss, stakingInfo }: Staki | |||
| </RowBetween> | |||
| {stakingInfo?.stakedAmount && ( | |||
| <AutoColumn justify="center" gap="md"> | |||
| <ThemedText.DeprecatedBody fontWeight={600} fontSize={36}> | |||
| <ThemedText.HeadlineLarge> | |||
There was a problem hiding this comment.
After adding HeadlineLarge from Figma, I did a quick search to replace places where DeprecatedBody was used to achieve same settings. Note that this is non-breaking, since DeprecatedBody text color is actually a textPrimary.
vm
reviewed
Dec 5, 2022
vm
reviewed
Dec 5, 2022
vm
reviewed
Dec 5, 2022
vm
reviewed
Dec 5, 2022
vm
reviewed
Dec 5, 2022
vm
approved these changes
Dec 5, 2022
|
Will wait for another pass, since I ended up doing few more changes! |
vm
approved these changes
Dec 5, 2022
|
Errors just got better 🎉 Now it's time to make sure this page appears less often! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements a new design of the error page as per Figma, aligns with new components/sizing where possible.
To reproduce, uncomment
isProductioncheck inindex.tsxto init Sentry and then, add the following:somewhere in the code, preferably in a top-level page component.
Todo: