Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Indicate a fulfillment without a document and part #683

Closed
rolandkla opened this issue Sep 5, 2024 · 1 comment · Fixed by #695
Closed

Indicate a fulfillment without a document and part #683

rolandkla opened this issue Sep 5, 2024 · 1 comment · Fixed by #695
Assignees
Labels
improvements New feature or request
Milestone

Comments

@rolandkla
Copy link
Collaborator

Context

A fulfilment contains ticket information such as the control number, status and its related document(s). It is possible that an OSDM provider returns a fulfilment (because of the control number and status) but it does not return any documents or parts.
This is the case where a distributor generates the documents on behalf of the provider.

In this case, when an OSDM client fetches a booking it is not aware if the documents/parts are yet to be generated or if they will remain absent on purpose. This could lead to clients polling without result.

Potential solution
Extending the fulfilment object with an indicator to inform the client that documents/parts should be expected, then the client knows if it has to wait for documents or not.
This can be achieved by introducing a status or a property indicator.

@rolandkla rolandkla added this to the 3.4.0 milestone Sep 5, 2024
@rolandkla rolandkla self-assigned this Sep 5, 2024
@jspetrak jspetrak moved this to To do in OSDM Specification Sep 6, 2024
@jspetrak jspetrak added the improvements New feature or request label Sep 6, 2024
@CGantert345
Copy link
Contributor

Proposal:

add an indication "ContentComplete" in Fulfillment:

  • false: content or additional content (documents or fulfillment parts) will be provided.
  • true: content (documents or fulfillment parts) provided iscomplete. If no content is included this is intentional.

TODO: pull request Josef

@CGantert345 CGantert345 moved this from To do to In progress in OSDM Specification Sep 20, 2024
@jspetrak jspetrak linked a pull request Sep 21, 2024 that will close this issue
@jspetrak jspetrak moved this from In progress to In review in OSDM Specification Sep 21, 2024
CGantert345 added a commit that referenced this issue Sep 26, 2024
…llment-content-complete

#683 Indicator Fulfillment.contentComplete
@CGantert345 CGantert345 moved this from In review to Done in OSDM Specification Sep 26, 2024
@schlpbch schlpbch changed the title Indicator for a fulfilment without a document and part Indicate a fulfillment without a document and part Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvements New feature or request
Projects
Development

Successfully merging a pull request may close this issue.

3 participants