Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify layouts in /availabilities/place-map #547

Closed
schlpbch opened this issue May 16, 2024 · 1 comment · Fixed by #562
Closed

Clarify layouts in /availabilities/place-map #547

schlpbch opened this issue May 16, 2024 · 1 comment · Fixed by #562
Assignees
@schlpbch
Labels
question Further information is requested
Milestone
3.3.0

Comments

@schlpbch
Copy link
Collaborator

schlpbch commented May 16, 2024 •
edited
Loading

We have three layout ids

  • layoutId
  • layoutLowerDeck - should be layoutLowerDeckId
  • layoutUpperDeck - should be layoutUpperDeckId

In case of two deck vehicles what is to be set on layoutId?

Proposal: layoutId denotes per definition the layoutLowerDeck.
@schlpbch schlpbch self-assigned this May 16, 2024
@schlpbch schlpbch added the question Further information is requested label May 16, 2024
@schlpbch schlpbch added this to the 3.3.0 milestone May 16, 2024
@jspetrak jspetrak moved this to To do in OSDM Specification May 16, 2024
@jspetrak jspetrak moved this from To do to In progress in OSDM Specification May 17, 2024
@jspetrak
Copy link
Collaborator

ADD comment on layoutId that it links to layout combining both decks together if multiple decks are in the vehicle

schlpbch added a commit that referenced this issue May 27, 2024
@schlpbch
document layoutId in case of two deck vehicles (#547)
73b96da
@schlpbch schlpbch mentioned this issue May 27, 2024
Merged
schlpbch added a commit that referenced this issue May 27, 2024
@schlpbch
Merge pull request #562 from UnionInternationalCheminsdeFer/feature/5…
0738083 
…47-clarify-layoutId

document layoutId in case of two deck vehicles (#547)
@jspetrak jspetrak moved this from In progress to Done in OSDM Specification May 31, 2024
@jspetrak jspetrak linked a pull request May 31, 2024 that will close this issue
document layoutId in case of two deck vehicles (#547) #562
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schlpbch schlpbch

Labels
question Further information is requested
Projects
OSDM Specification
Status: Done
Milestone
3.3.0
Development

Successfully merging a pull request may close this issue.

document layoutId in case of two deck vehicles (#547) UnionInternationalCheminsdeFer/OSDM
2 participants
@jspetrak @schlpbch