Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Constrain snmpsim version to not 1.1.6 #370

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

johannaengland
Copy link
Contributor

@johannaengland johannaengland commented Sep 13, 2024

Scope and purpose

The version 1.1.6 breaks. Versions 1.0.0 to 1.1.5 and the newest version 1.1.7 work.

This pull request

  • changes a dependency

Contributor Checklist

Every pull request should have this checklist filled out, no matter how small it is.
More information about contributing to Zino can be found in the
README.

  • Added a changelog fragment for towncrier
  • Added/amended tests for new/changed code
  • Added/changed documentation
  • Linted/formatted the code with black, ruff and isort, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/
  • If applicable: Created new issues if this PR does not fix the issue completely/there is further work to be done

@johannaengland johannaengland added the dependencies Pull requests that update a dependency file label Sep 13, 2024
@johannaengland johannaengland self-assigned this Sep 13, 2024
Copy link

codecov bot commented Sep 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.66%. Comparing base (b19d9fa) to head (9b3c880).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #370   +/-   ##
=======================================
  Coverage   98.66%   98.66%           
=======================================
  Files          77       77           
  Lines        9711     9711           
=======================================
  Hits         9581     9581           
  Misses        130      130           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

The version 1.1.6 breaks, so this is making sure that one is not used
@johannaengland johannaengland changed the title Constrain snmpsim version to <1.1.6 Constrain snmpsim version to !=1.1.6 Sep 13, 2024
@johannaengland johannaengland changed the title Constrain snmpsim version to !=1.1.6 Constrain snmpsim version to not 1.1.6 Sep 13, 2024
Copy link

sonarcloud bot commented Sep 13, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant