Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch new SNMP errors in juniper alarm task #275

Conversation

johannaengland
Copy link
Contributor

Scope and purpose

Fixes #212.

This amends the changes made in #231 according to the new SNMP errors introduced/handled in #262.
This should finally lead to error being correctly handled and only things being logged if the device has an alarm count of an invalid type (but not none).

Contributor Checklist

  • Added a changelog fragment for towncrier
  • Linted/formatted the code with black, ruff and isort, easiest by using pre-commit
  • The first line of the commit message continues the sentence "If applied, this commit will ...", starts with a capital letter, does not end with punctuation and is 50 characters or less long. See https://cbea.ms/git-commit/

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.04%. Comparing base (5d77dc6) to head (a6f6a89).

Current head a6f6a89 differs from pull request most recent head 5670e2b

Please upload reports for the commit 5670e2b to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #275      +/-   ##
==========================================
+ Coverage   98.88%   99.04%   +0.16%     
==========================================
  Files          51       50       -1     
  Lines        6876     6776     -100     
==========================================
- Hits         6799     6711      -88     
+ Misses         77       65      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/zino/tasks/juniperalarmtask.py Outdated Show resolved Hide resolved
src/zino/tasks/juniperalarmtask.py Outdated Show resolved Hide resolved
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@johannaengland johannaengland force-pushed the bugfix/juniper-alarm-error-handling branch from a6f6a89 to 5670e2b Compare June 26, 2024 06:47
@johannaengland johannaengland merged commit bd40b26 into Uninett:master Jun 26, 2024
7 checks passed
@johannaengland johannaengland deleted the bugfix/juniper-alarm-error-handling branch June 26, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Alarm count is not int
2 participants