Add API command to create fake events #271
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #271 +/- ##
==========================================
+ Coverage 98.20% 98.21% +0.01%
==========================================
Files 64 64
Lines 7930 7969 +39
==========================================
+ Hits 7787 7826 +39
Misses 143 143 ☔ View full report in Codecov by Sentry. |
johannaengland
force-pushed
the
api/fake-event
branch
2 times, most recently
from
627dc08
to
c852b80
Compare
johannaengland
force-pushed
the
api/fake-event
branch
3 times, most recently
from
9591f9a
to
c49c994
Compare
johannaengland
force-pushed
the
api/fake-event
branch
2 times, most recently
from
5546eb8
to
f8ff1f2
Compare
johannaengland
force-pushed
the
api/fake-event
branch
from
f8ff1f2
to
3a33f0c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #268. Part of #243.
The reason why this is a draft PR is that I am not happy, that the subindex is not optional, because when trying to create a
ReachabilityEventit should be possible to only have the device name andreachabilityas input. But I do not know how to implement that.I was also considering having the possibility of no input or just the input of router and/or event type and randomly generating the other not given values. Is that desirable?