Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix serializing issues in planned maintenance #253

Merged
merged 3 commits into from
Jun 16, 2024
Merged

Conversation

stveit
Copy link
Contributor

@stveit stveit commented Jun 13, 2024

Bugfixes for planned maintenance added in #194 (for #61)

Fixes the ol' Pydantic problem where it struggles with subclasses if you dont specifically mention the subclasses instead of just referencing the parent. Adds some default values as there were some issues reading state back in if something was set to None but didnt have default value, I'm guessing None values arent written to the file.

Also changes how the type field for PMs are defined, as pydantic struggled to recreate the object with the correct subclass if Literal wasnt being used

Does this need a towncrier file?

Copy link

github-actions bot commented Jun 13, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 78 0 1.27s
✅ PYTHON isort 78 0 0.29s
✅ PYTHON ruff 78 0 0.02s

See detailed report in MegaLinter reports

MegaLinter is graciously provided by OX Security

Copy link

github-actions bot commented Jun 13, 2024

Test results

    3 files      3 suites   52s ⏱️
  381 tests   381 ✅ 0 💤 0 ❌
1 143 runs  1 141 ✅ 2 💤 0 ❌

Results for commit 2c18a57.

♻️ This comment has been updated with latest results.

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.99%. Comparing base (bbccc90) to head (2c18a57).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #253   +/-   ##
=======================================
  Coverage   98.99%   98.99%           
=======================================
  Files          50       50           
  Lines        6740     6740           
=======================================
  Hits         6672     6672           
  Misses         68       68           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@johannaengland
Copy link
Contributor

Does this need a towncrier file?

I think it would be nice, just for the person creating the release to be able to group this and the original PM PR together

@hmpf
Copy link
Contributor

hmpf commented Jun 13, 2024

Does this need a towncrier file?

I think it would be nice, just for the person creating the release to be able to group this and the original PM PR together

If there hasn't been a release (as in: on pypi) of the pm functionality then I don't see why there needs to be something grouped together. Then again, I don't see why mentioning PR numbers in the chaneglog are necessary.

@stveit stveit self-assigned this Jun 13, 2024
Copy link

sonarcloud bot commented Jun 13, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stveit stveit merged commit b1ffc1c into master Jun 16, 2024
9 of 10 checks passed
@lunkwill42 lunkwill42 deleted the fix/pm-serializing branch July 9, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants