-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dump event content to file on deletion #204
Dump event content to file on deletion #204
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #204 +/- ##
=======================================
Coverage 98.77% 98.77%
=======================================
Files 41 41
Lines 5457 5466 +9
=======================================
+ Hits 5390 5399 +9
Misses 67 67 ☔ View full report in Codecov by Sentry. |
ad37282
to
7fc3ab9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For me, the format is just as expected. This is a big part of the reason we have employed Pydantic in Zino 2 :)
I would approve, but the dependent PR needs to be fixed and merged first!
7fc3ab9
to
bd3e7ae
Compare
Quality Gate passedIssues Measures |
Closes #182. Dependent on #203.
The format of the way the event is dumped can be discussed, I did it the easiest way for now.