Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dump event content to file on deletion #204

Merged

Conversation

johannaengland
Copy link
Contributor

Closes #182. Dependent on #203.

The format of the way the event is dumped can be discussed, I did it the easiest way for now.

@johannaengland johannaengland added the blocked This issue needs something else to be done before it can be resolved label Apr 3, 2024
@johannaengland johannaengland self-assigned this Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.77%. Comparing base (8c40d0d) to head (7328aa6).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #204   +/-   ##
=======================================
  Coverage   98.77%   98.77%           
=======================================
  Files          41       41           
  Lines        5457     5466    +9     
=======================================
+ Hits         5390     5399    +9     
  Misses         67       67           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Apr 3, 2024

Test results

    3 files      3 suites   32s ⏱️
297 tests 297 ✔️ 0 💤 0
891 runs  889 ✔️ 2 💤 0

Results for commit 7328aa6.

♻️ This comment has been updated with latest results.

@johannaengland johannaengland force-pushed the feature/dump-event-to-file-on-delete branch from ad37282 to 7fc3ab9 Compare April 3, 2024 12:47
Copy link
Member

@lunkwill42 lunkwill42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For me, the format is just as expected. This is a big part of the reason we have employed Pydantic in Zino 2 :)

I would approve, but the dependent PR needs to be fixed and merged first!

@johannaengland johannaengland removed the blocked This issue needs something else to be done before it can be resolved label Apr 8, 2024
@johannaengland johannaengland force-pushed the feature/dump-event-to-file-on-delete branch from 7fc3ab9 to bd3e7ae Compare April 8, 2024 12:44
Copy link

sonarcloud bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@lunkwill42 lunkwill42 merged commit be13229 into Uninett:master Apr 9, 2024
8 checks passed
@johannaengland johannaengland deleted the feature/dump-event-to-file-on-delete branch April 9, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a task that automatically deletes closed events after a certain time
2 participants