This repository has been archived by the owner on Jan 28, 2020. It is now read-only.
Add ability to set cookie expiry time #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olavmrk
suggested changes
Nov 13, 2018
There was a problem hiding this comment.
Hi,
could you take a look at my two review comments. I'd also like to see the new option added to the example config in README.md. In addition, please squash the commits together and add a commit message which follows the more traditional format (i.e. a header line which is short enough not to wrap and a body describing what and why).
Ability to make cookies live long then browser session :
|
Closing this pull request as part of archiving this project. See the announcement for details: https://github.com/Uninett/mod_auth_mellon/blob/info/README.md |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mellon doesn't set the cookie expiry time thereby it defaults to browser session, this lets the time be set in seconds in the future from now.