Trigger workflow in argus-docker on release #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The triggered workflow will take the sent repository name and version number to update its dockerfile
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #859 +/- ##
=======================================
Coverage 84.29% 84.29%
=======================================
Files 86 86
Lines 3973 3973
=======================================
Hits 3349 3349
Misses 624 624 ☔ View full report in Codecov by Sentry. |
|
hmpf
reviewed
Aug 30, 2024
There was a problem hiding this comment.
Looks good to me but I think @lunkwill42 should also have a look.
lunkwill42
approved these changes
Sep 2, 2024
I've had a look, and it seems like the expected approach to me. Haven't built this type of solution with GitHub before, so can't say for sure if it will work before we try it the first time. |
johannaengland
deleted the
workflows/trigger-workflow-in-argus-docker-on-release
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will trigger the workflow added in Uninett/argus-docker#6.
Another part to close Uninett/argus-docker#4.
To get this to work we need to install a GitHub App that has the permissions to trigger workflows in Argus. This app will be used by the used GitHub action create-github-app-token to create a token with the necessary permissions.