Only update affected row when updating destination in HTMX frontend #1121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stveit
force-pushed
the
htmx-destination-delete-only-affected-row
branch
from
a4325bf to
fdfda05
Compare
stveit
force-pushed
the
htmx-destination-update-only-affected-row
branch
from
f66e72e to
5d0426b
Compare
Test results 10 files 1 050 suites 38m 7s ⏱️ Results for commit fe961ed. ♻️ This comment has been updated with latest results. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## htmx-destination-delete-only-affected-row #1121 +/- ##
=============================================================================
+ Coverage 79.86% 79.97% +0.10%
=============================================================================
Files 145 145
Lines 5265 5258 -7
=============================================================================
Hits 4205 4205
+ Misses 1060 1053 -7 ☔ View full report in Codecov by Sentry. |
After changes to update_htmx, this part is no longer used
stveit
force-pushed
the
htmx-destination-update-only-affected-row
branch
from
5d0426b to
fe961ed
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1073
based on #1120
Makes it so only the row for the destination you try to delete is updated with HTMX.