Run nginx completely unprivileged in container #592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This switches the production Docker image to use the nginx-unprivileged image as its base. The original image would start nginx as root, while nginx itself would drop privileges to the nginx user. This updated workflow will ensure nothing is started as root at all when the container starts.
There is no need to install the `tree` command into the container image (some old version of the image may have used it, but this hasn't been true for a while).
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #592 +/- ##
=======================================
Coverage 57.34% 57.34%
=======================================
Files 86 86
Lines 3692 3692
Branches 837 840 +3
=======================================
Hits 2117 2117
Misses 1566 1566
Partials 9 9 ☔ View full report in Codecov by Sentry. |
This reduces the size of the resulting image by avoiding filling the container filesystem with the apk package cache (as suggested by SonarCloud)
|
hmpf
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This switches the production Docker image to use the nginx-unprivileged image as its base. The original image would start nginx as root, while nginx itself would drop privileges to the nginx user.
This updated workflow will ensure nothing is started as root at all when the container starts.
Fixes #591