This repository has been archived by the owner on Jan 9, 2020. It is now read-only.
Clean-up and improve Isentropic Analysis notebook #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zbruick
approved these changes
Aug 12, 2019
| "temperature.attrs['units'] = 'kelvin'\n", | ||
| "lev_uwnd.attrs['units'] = 'Pa'" | ||
| "# Get common pressure levels as a data array\n", | ||
| "press = press.metpy.sel(vertical=common_levels)" |
There was a problem hiding this comment.
Should we be going back and reworking other examples that use this common levels hack with this method that you have here?
There was a problem hiding this comment.
Maybe? Probably on a case-by-base basis. Anywhere we're doing something more complicated to handle differing vertical levels.
|
Seems to be a weird bug in MetPy, but only in master. See Unidata/MetPy#1124. In the meantime, I've adjusted the code to (I think) work on 0.10.2 and master. |
|
Restarted Travis. Errored out on the NCSS notebook with THREDDS issues. Otherwise, this looks good. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes a few needless cells near the end that look at units. Also rework to use metpy accessor and simplify the process of selecting common levels in the fields.