Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suppress filters on variables with non-fixed-size types. #2716

Merged
merged 4 commits into from
Jun 26, 2023

Commits on Jun 20, 2023

  1. mam2

    DennisHeimbigner committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    878dc46 View commit details
    Browse the repository at this point in the history
  2. revert

    DennisHeimbigner committed Jun 20, 2023
    Configuration menu
    Copy the full SHA
    9a5a6aa View commit details
    Browse the repository at this point in the history

Commits on Jun 21, 2023

  1. Suppress filters on variables with non-fixed-size types.

    re: Discussion Unidata#2554
    re: PR Unidata#2231
    re: Issue Unidata#2189
    
    After some discussion, the issue of applying filters on variables
    whose type is not fixed size, was resolved as follows:
    1. A call to nc_def_var_filter will ignore such filters, but will issue a log warning.
    2. Loading (from an existing file) a variable whose type is not fixed-size and which has filters, will cause the variable to be suppressed.
    
    This PR enforces those rules.
    
    ### Misc. Other changes
    * Add a test case to test the vlen change.
    * Make some minor clean-ups in various cmake and automake files.
    * Remove unused test
    DennisHeimbigner committed Jun 21, 2023
    Configuration menu
    Copy the full SHA
    8cab468 View commit details
    Browse the repository at this point in the history

Commits on Jun 23, 2023

  1. Configuration menu
    Copy the full SHA
    fb422e6 View commit details
    Browse the repository at this point in the history