Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the configuration fails on macOS with the
--disable-libxml2
option:configure: error: Error: OSX requires libxml2 => --disable-dap4.
The configuration fails even if we add an extra option
--disable-dap
.Also, one of the two lines here is redundant: the configuration should either fail or override the user's choice and proceed. Although I personally prefer the former, the latter seems to be a common pattern in the configure script. Therefore, this MR switches from
AC_MSG_ERROR
toAC_MSG_WARN
and modifies the misleading message (there is no option--disable-dap4
). It also doesn't make sense to emit the message and setenable_dap4
tono
if the variable is already set tono
.I am not sure, whether the problem fixed with 6d44ec3 is still relevant because I have just managed to build the library with the bundled XML implementation.