Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix building on macOS #2710

Merged
merged 1 commit into from
Jun 13, 2023
Merged

Conversation

skosukhin
Copy link
Contributor

Currently, the configuration fails on macOS with the --disable-libxml2 option:

configure: error: Error: OSX requires libxml2 => --disable-dap4.

The configuration fails even if we add an extra option --disable-dap.

Also, one of the two lines here is redundant: the configuration should either fail or override the user's choice and proceed. Although I personally prefer the former, the latter seems to be a common pattern in the configure script. Therefore, this MR switches from AC_MSG_ERROR to AC_MSG_WARN and modifies the misleading message (there is no option --disable-dap4). It also doesn't make sense to emit the message and set enable_dap4 to no if the variable is already set to no.

I am not sure, whether the problem fixed with 6d44ec3 is still relevant because I have just managed to build the library with the bundled XML implementation.

@DennisHeimbigner
Copy link
Collaborator

Thanks for catching this. Ideally, we would fail the build if the user explicitly set some option that
we needed to disable, --enable-dap, in this case, I think. If the option is not set explicitly, then
we try to disable and give a warning. Unfortunately, under current build systems, it can be difficult to tell
if a an explicit option was given. If we give a warning, then it often gets overlooked by the user.
In this case, I think giving a warning is the correct action, as you note.
Also, good to hear that tinyxml2 built under OSX. That would allow us to clean up the configure.ac file a bit.

DennisHeimbigner added a commit to DennisHeimbigner/netcdf-c that referenced this pull request Jun 13, 2023
re: PR Unidata#2710

Apparently (see above PR) tinyxml2 now works under OS/X.
So this PR is a follow on to the above PR. It modifies
our OS/X github action to test tinyxml2 under OS/X.
@DennisHeimbigner DennisHeimbigner merged commit cfe6231 into Unidata:main Jun 13, 2023
DennisHeimbigner added a commit to DennisHeimbigner/netcdf-c that referenced this pull request Jun 13, 2023
re: PR Unidata#2710

Apparently (see above PR) tinyxml2 now works under OS/X.
So this PR is a follow on to the above PR. It modifies
our OS/X github action to test tinyxml2 under OS/X.
petscbot pushed a commit to petsc/petsc that referenced this pull request Dec 4, 2023
- add in fix for for OSX bug
Unidata/netcdf-c#2710

- add in fix hdf5 for failure on freebsd
HDFGroup/hdf5#3883

- add fix for hdf5 failure with -fp_trap failure
HDFGroup/hdf5#3837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants