Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New PlotSurfaceAnalysis class to plot WPC surface analysis bulletins #3580

Merged
merged 15 commits into from
Aug 28, 2024

Conversation

anacmontoya
Copy link
Contributor

@anacmontoya anacmontoya commented Jul 22, 2024

Description Of Changes

Added new class to plot the WPC surface bulletins that have been parsed using parse_wpc_surface_bulletin() function.
Some documentation has been added but may need some edits. Currently working on tests.

Checklist

  • Tests added
  • Fully documented

@anacmontoya anacmontoya requested review from kgoebber and a team as code owners July 22, 2024 23:03
@anacmontoya anacmontoya requested review from dcamron and removed request for a team July 22, 2024 23:03
@anacmontoya anacmontoya marked this pull request as draft July 22, 2024 23:04
Copy link
Member

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a few minor changes to get this solid for inclusion.

src/metpy/plots/declarative.py Outdated Show resolved Hide resolved
src/metpy/plots/declarative.py Outdated Show resolved Hide resolved
src/metpy/plots/declarative.py Outdated Show resolved Hide resolved
src/metpy/plots/declarative.py Outdated Show resolved Hide resolved
src/metpy/plots/declarative.py Outdated Show resolved Hide resolved
src/metpy/plots/declarative.py Outdated Show resolved Hide resolved
@anacmontoya
Copy link
Contributor Author

"Biggest" change from last commit was changing the default strength_offset. It is then scaled by multiplying by 0.8*label_fontsize

tests/plots/test_declarative.py Dismissed Show dismissed Hide dismissed
tests/plots/test_declarative.py Dismissed Show dismissed Hide dismissed
anacmontoya and others added 6 commits July 31, 2024 11:40
Scattertext supports same config with
TextCollection under the hood, and has hack for
bbox clipping with cartopy. Fix style.
.codespellignore Outdated Show resolved Hide resolved
@anacmontoya anacmontoya marked this pull request as ready for review July 31, 2024 22:38
@anacmontoya anacmontoya changed the title New Plot_Bulletin class to plot WPC surface analysis bulletins New PlotSurfaceAnalysis class to plot WPC surface analysis bulletins Jul 31, 2024
@dopplershift dopplershift added this to the 1.7.0 milestone Aug 1, 2024
@dopplershift dopplershift merged commit ddc198c into Unidata:main Aug 28, 2024
35 checks passed
@dopplershift dopplershift added Type: Feature New functionality Area: Plots Pertains to producing plots labels Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Plots Pertains to producing plots Type: Feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants