-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New PlotSurfaceAnalysis class to plot WPC surface analysis bulletins #3580
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
requested changes
Jul 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a few minor changes to get this solid for inclusion.
"Biggest" change from last commit was changing the default strength_offset. It is then scaled by multiplying by 0.8*label_fontsize |
Scattertext supports same config with TextCollection under the hood, and has hack for bbox clipping with cartopy. Fix style.
…MetPy into plot-bulletin-class
dcamron
reviewed
Jul 31, 2024
anacmontoya
changed the title
New Plot_Bulletin class to plot WPC surface analysis bulletins
New PlotSurfaceAnalysis class to plot WPC surface analysis bulletins
Jul 31, 2024
dopplershift
approved these changes
Aug 28, 2024
dopplershift
added
Type: Feature
New functionality
Area: Plots
Pertains to producing plots
labels
Aug 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Added new class to plot the WPC surface bulletins that have been parsed using
parse_wpc_surface_bulletin()
function.Some documentation has been added but may need some edits. Currently working on tests.
Checklist