extend declarative colorbar functionality #3181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcamron
approved these changes
Sep 13, 2023
There was a problem hiding this comment.
I wish this could mirror your additions proposed in #3183, but since we already have a public colorbar trait (as opposed to eg colorbar_orientation), I suppose it wouldn't make much sense to add in a colorbar_args. I think this is the best solution contained within the existing colorbar trait. I'll wait briefly for other input from yourself or others before I kick this in. Thanks!
dcamron
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
This PR addresses the lack of ability to control the colorbar that was brought up in Issue #2746
With this PR, the colorbar trait can be set with a string giving the orientation of the colorbar and using our predefined values for aspect and pad OR a user can set the trait to a dictionary of Matplotlib colorbar kwargs to have more control.
Checklist