-
Notifications
You must be signed in to change notification settings - Fork 415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wet bulb potential temperature #2952
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! At first I was concerned this would be fundamentally different from the Bolton 1980 stuff we've used before, but I see this actually explicitly relies on it--that's great! Just a few minor tweaks to improve the docs (especially for the web) and to improve the implementation a bit. Otherwise, it looks good!
@sec147 just pinging to see if you have any cycles to address the comments on this PR and ability to rebase on main and address any conflicts that might have crept in while this was being worked on. If not, just let us know and we can move it forward from what you have submitted up to this point. |
45a0c72
to
cdb74b6
Compare
…lent potential temperature function and formula given in DaviesJones2009
Ok, git surgery taken care of. I think this is good to go, but I added a commit renaming Need a review from @dcamron since I committed here. |
Description Of Changes
Add function to calculate wet bulb potential temperature to calcs, with associated docstring and (minimal) test.
This is my first ever pull request - I've read all the docs and tested and think it's ok. Would value feedback.
Checklist