Still further updates to pint master branch compatibility #1261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dopplershift
added
Area: Units
dopplershift
approved these changes
Dec 30, 2019
| @@ -28,6 +29,7 @@ | |||
|
|
|||
| # Must occur before below imports | |||
| warnings.filterwarnings('ignore', 'numpy.dtype size changed') | |||
| os.environ['PINT_ARRAY_PROTOCOL_FALLBACK'] = '0' | |||
There was a problem hiding this comment.
Is there a reason this is here and not in units.py?
There was a problem hiding this comment.
If it is here, then we don't need the import order break and # noqa in units.py, but I can easily change it to that if it is preferred.
There was a problem hiding this comment.
Ok, that's fine. Let's leave it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
In what is becoming a recurring pattern (#1144, #1250), MetPy has conflicts with the current state of Pint's master branch! This PR
Nones for non-unit arguments with@units.wraps(without this, pytest will not run due to anImportError)wet_bulb_temperatureto not assume unit is strippedPINT_ARRAY_PROTOCOL_FALLBACKenvironment variable to '0' to disable Pint's problematic__array_struct__and__array_interface__fallback (xref Proper handling of__array_*__attributes/methods hgrecco/pint#924)This is likely needed ASAP, since Pint v0.10 is expected out soon
Checklist