Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expanding on the naming conventions #793
base: master
Are you sure you want to change the base?
Expanding on the naming conventions #793
Changes from 19 commits
5d1c20b
18e63c4
efd8af3
d8a9cd6
671b890
0b4e67b
1f470b1
3d521a8
92c28a4
f1e82f9
d9ee159
e91cf2e
0ab40db
a44bd45
2b17fa6
1d30aa6
c922269
4ac7ec8
cc82fac
e91085b
88a9226
74e0697
a8bfc8f
6f88244
fa770b4
633b471
bd3ed0b
0b27816
63a0091
1f95642
fdea201
693cb0f
1fbc9b9
6006e80
81f66b8
fce34cd
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hom-iso-Group
has the approximate typeiso -> hom
, shouldn't it then be[type]-[hypotheses]-[Namespace]
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That looks right
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this
[type]-[hypotheses]-[Namespace]
?is-iso
being the type andiso
being the hypothesis. If not, what's the difference between this and the exampleis-ideal-ideal-Ring
below?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Things that go under [type] are the output types of the specification of an entry. In the case of
is-iso-hom-Ring
the output type of its specification isUU
. We don't put this in the name. Insteadis-iso
is a descriptor of the specification, falling under[name]
in the general pattern.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think I follow. What I'm reading is that
is-iso-iso-Group : (f : iso) -> is-iso f
follows[type]-[Namespace]
, butis-ideal-ideal-Ring : (I : ideal) -> is-ideal I
follows[type]-[hypotheses]-[Namespace]
Is that correct?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But
kernel-hom
isn't a hypothesis here, isn't it more of a[type]-[name]-[Namespace]
thing?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also say that this is
[type]-[name]
, or possibly[type]-[name]-[Namespace]
, because otherwise aren't you saying thatleft-unit-law-mul
is a type?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm saying that
left-unit-law mul-ℤ
is a type.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then I don't see where the
[Namespace]
part comes in? Since the-Z
suffix is already in the[type]
part.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But if it were counted in the type part, then we'd have to say
interchange-law-add-ℤ-add-ℤ
. Instead, here the proposal is to considerℤ
in the namespace part. The name of the type we're landing in of course also mentions the namespace, but in a namespace you don't repeat the name of the namespace for every entry in it that you use. Instead, within the namespace the type would beleft-unit-law mul
, which would appear in the name of an entry asleft-unit-law-mul
, and we append the namespace.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW, all of these are very good questions. I will try to clear it up in the text too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, that does make it way clearer, thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Again I'd say this is
[type]-[name]-[Namespace]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The type of the output of this entry is
interchange-law add-ℤ add-ℤ
, so the name here merely describes the type, and the namespace for the integers. In the caseis-equiv-succ-ℤ : is-equiv succ-ℤ
this would also fall under[type]-[Namespace]
.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The explanation on
left-unit-law-mul-ℤ
makes this clear now 👌There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd also mention the homotopy composition and whiskering situation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other examples are the asterisk vs asterisk operator, and big vee vs small vee. Maybe rephrase to "try to avoid subtly different"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although the second example here is also an instance of using a variable in a name, perhaps it still conveys the correct sentiment.