fastapi demo #46
fastapi demo #46
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @longsihua2003, thanks for opening your first pull request 😊! We really appreciate your work. Happy Coding 🎉🎊 !
|
run |
ecjtu/ecjtu_api/server.py
Outdated
| @@ -0,0 +1,18 @@ | |||
| #TODO | |||
ecjtu/ecjtu_api/auth.py
Outdated
| @@ -0,0 +1,12 @@ | |||
| import base64 | |||
| # from ecjtu.client import _get_enc_password | |||
| KEY = "zxcvbnmasdgfhjklpoiuytrewq" | |||
ecjtu/ecjtu_api/ecjtu_schema.py
Outdated
| @@ -0,0 +1,5 @@ | |||
| from pydantic import BaseModel, Field | |||
There was a problem hiding this comment.
This file named schema is enough.
ecjtu/ecjtu_api/respose_result.py
Outdated
| """ | ||
| 构建response返回结果 | ||
| { | ||
| "code": 200, | ||
| "msg": "success", | ||
| "data": { | ||
| "name": "张三", | ||
| "age": 18 | ||
| } | ||
| } | ||
| """ |
ecjtu/ecjtu_api/server.py
Outdated
| client = ECJTU(stud_id=args.stud_id, password=args.pwd) | ||
| client.start_api_server(port=args.port) |
ecjtu/ecjtu_api/api.py
Outdated
| # 启动api服务 | ||
| def start_api_server(): | ||
| import uvicorn | ||
| uvicorn.run(app, host="127.0.0.1", port=8080) |
There was a problem hiding this comment.
The port must be configurable.
ecjtu/utils/cookie.py
Outdated
| def cookies_tolist(cookies: Optional[CookieTypes]): | ||
| cookies_list = [] | ||
| for cookie in cookies.jar: | ||
| dict = { |
There was a problem hiding this comment.
Dict is a key word. Change the name.
|
Add usage In readme |
ecjtu/ecjtu_api/api.py
Outdated
|
|
||
| from ecjtu.client import ECJTU | ||
|
|
||
| from . import auth, middle, respose_result, schema |
There was a problem hiding this comment.
from ecjtu.ecjtu_API import...
ecjtu/ecjtu_api/auth.py
Outdated
| return create_tokens(stud_id, pwd)[0] | ||
|
|
||
|
|
||
| # 验证和读取access_token的stud_id |
There was a problem hiding this comment.
All comments use Google code guidelines. Use function type comment.
https://google.github.io/styleguide/pyguide.html
You can set Google code style in pycharm.
ecjtu/ecjtu_api/respose_result.py
Outdated
| class ResponseResult: | ||
| @staticmethod | ||
| def success( | ||
| data: Union[Dict[str, Any], Any] = None, msg: str = "success" |
There was a problem hiding this comment.
This makes me a little confused. Any means any type. It doesn't make sense to go with Union
|
lgtm |
Undertone0809
added
documentation
About the addition of fastapi