Hide child code entries in main tree #1926
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
which filters child code entries from the code list on top of the normal filtering done by FilteringViewConverter.
The setting has no tooltip as of yet.
also correct accessibility levels in FilteredViewConverter and CodeViewConverter.
|
Download the artifacts for this pull request here: GUI:
CLI: |
🤔 "Hides code entries corresponding to sub-functions of scripts in GMS2.3 games"
Our main focus is UT/DR, and since in DR Ch1&2 scripts containing multiple subfunctions are not common, making the child code entries mostly noise, I feel it would be fair to hide them by default for now |
- Add setting tooltip. - Make the setting on by default.
|
Done and done
It seems neither can I. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements #1609. Adds a setting to the settings menu to control whether the child code entries (entries which have ParentEntry set) are hidden or shown in the main tree.
Caveats
The are 2 tiny things that need to be adressed before this can be merged:
Notes
Resolves #1609.