Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for silverstripe 5 #79

Merged

Conversation

satrun77
Copy link
Contributor

@satrun77 satrun77 commented Feb 12, 2023

Update composer to support silverstripe 5. Tested with CMS 5 beta-1

@satrun77 satrun77 marked this pull request as ready for review February 12, 2023 23:18
@UndefinedOffset
Copy link
Owner

Part of me wonders given the APIs are so similar if this should be something like, we could tighten it down later if the APIs diverge to the point that it causes issues.

  • silverstripe/framework ^4 | ^5
  • silverstripe/vendor-plugin ^1.0 | ^2.0
  • silverstripe/spamprotection ^3 | ^4

@UndefinedOffset
Copy link
Owner

Have a look at https://github.com/webbuilders-group/silverstripe-turnstile/blob/master/composer.json, also I'm pretty sure we can drop silverstripe/vendor-plugin now it's part of the core's dependencies so it's not needed even in 4.x.

@satrun77
Copy link
Contributor Author

@UndefinedOffset PR updated

@UndefinedOffset UndefinedOffset merged commit 5019c9d into UndefinedOffset:master Feb 13, 2023
@UndefinedOffset
Copy link
Owner

Thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants