Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for iya strategy v1 #699

Merged
merged 51 commits into from
Nov 20, 2023
Merged

Update for iya strategy v1 #699

merged 51 commits into from
Nov 20, 2023

Conversation

jununifi
Copy link
Contributor

@jununifi jununifi commented Sep 1, 2023

No description provided.

@jununifi jununifi marked this pull request as draft September 1, 2023 12:26
@Senna46
Copy link
Contributor

Senna46 commented Oct 3, 2023

I fixed a bug that allowed LPs to be issued even when the token was different from the vault denom.

jununifi and others added 21 commits October 3, 2023 20:39
@jununifi jununifi marked this pull request as ready for review November 1, 2023 12:26
kimurayu45z
kimurayu45z previously approved these changes Nov 6, 2023
@Senna46
Copy link
Contributor

Senna46 commented Nov 14, 2023

@jununifi I think it need to make sure that the symbol in strategies and vault match when creating the vault.

Also, we need a query to find the strategy by Symbol. As strategies with the same symbol in different denom can be put in the same vault.
Adding a symbol field to the strategy can also solve this problem.

@Senna46 Senna46 merged commit 66839f0 into develop Nov 20, 2023
2 checks passed
@Senna46 Senna46 deleted the feat/iya_strategy_v1 branch November 20, 2023 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants