Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: redeem query #693

Merged
merged 4 commits into from
Aug 28, 2023
Merged

fix: redeem query #693

merged 4 commits into from
Aug 28, 2023

Conversation

Senna46
Copy link
Contributor

@Senna46 Senna46 commented Aug 25, 2023

Change

  • Added withdrawFee to the Fee value.
  • ShareAmount is changed to the amount before fees are subtracted (EstimateRedeemAmountInternal).

@Senna46 Senna46 requested a review from jununifi August 25, 2023 12:35
@kimurayu45z kimurayu45z merged commit 22fd22d into develop Aug 28, 2023
2 checks passed
@kimurayu45z kimurayu45z deleted the fix/redeem branch August 28, 2023 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kimurayu45z kimurayu45z kimurayu45z approved these changes

@jununifi jununifi Awaiting requested review from jununifi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Senna46 @kimurayu45z