Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade 3.2-nftfactory, pob & ibc-hook #660

Merged
merged 27 commits into from
Aug 15, 2023
Merged

Conversation

Senna46
Copy link
Contributor

@Senna46 Senna46 commented Aug 8, 2023

This upgrade includes nftfactory, Skip-pob and ibc-hook

If merge #653 this time, edit app.go after the merge

@Senna46
Copy link
Contributor Author

Senna46 commented Aug 8, 2023

It is incorrect to have a commission ratio of Int.
0.5%, etc. cannot be set.

This PR changes this Int to Dec.

@Senna46 Senna46 mentioned this pull request Aug 8, 2023
@Senna46
Copy link
Contributor Author

Senna46 commented Aug 9, 2023

Version error in _nftbackedloan store. I'm currently fixing this error. expected 166 got 0

@Senna46
Copy link
Contributor Author

Senna46 commented Aug 10, 2023

Error

3:58PM ERR error on loading last version err="failed to load latest version: version of store _nftbackedloan mismatch root store's version; expected 31 got 0; new stores should be added using StoreUpgrades" module=server

Need to check why the store already exists

@Senna46 Senna46 changed the title Upgrade 3.2-backedloan & pob Upgrade 3.2-nftfactory, pob & ibc-hook Aug 15, 2023
@Senna46
Copy link
Contributor Author

Senna46 commented Aug 15, 2023

Error

3:58PM ERR error on loading last version err="failed to load latest version: version of store _nftbackedloan mismatch root store's version; expected 31 got 0; new stores should be added using StoreUpgrades" module=server

Need to check why the store already exists

nftbackedloan and nftfactory have different Storekey and ModuleName, so Storekey must be set correctly for StoreUpgrade.

Added: []string{nftfactorytypes.StoreKey, buildertypes.StoreKey, ibchookstypes.StoreKey},

@Senna46 Senna46 merged commit a879ef8 into newDevelop Aug 15, 2023
2 checks passed
@Senna46 Senna46 deleted the upgrade3.2-backedloan branch August 15, 2023 06:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants