Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Impl unit tests of margin msgs (AddMargin and WithdrawMargin) #631

Merged
merged 3 commits into from
Jun 26, 2023
Merged

Impl unit tests of margin msgs (AddMargin and WithdrawMargin) #631

merged 3 commits into from
Jun 26, 2023

Conversation

taiki1frsh
Copy link
Collaborator

@taiki1frsh taiki1frsh commented Jun 26, 2023 •
edited
Loading

close #626

  • Implement unit tests of AddMargin and WithdrawMargin
  • Fix function call in other test
  • Modify the way to subtract in WithdrawMargin

@taiki1frsh taiki1frsh requested a review from Senna46 June 26, 2023 04:44
@taiki1frsh taiki1frsh changed the base branch from newDevelop to feature/add-margin-to-any-positions June 26, 2023 04:45
@Senna46 Senna46 merged commit 85b8bee into feature/add-margin-to-any-positions Jun 26, 2023
@Senna46 Senna46 deleted the feature/impl_unit_tests_of_margin_msgs branch June 26, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Senna46 Senna46 Senna46 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[derivatives] Implement unit tests for AddMargin and WithdrawMargin
2 participants
@taiki1frsh @Senna46