Psb: sanitize ImageMetadata.Name to prevent invalid file name error
#104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice catch, but the solution is kind of wrong. Would you like to share a sample .mtn file by the way? |
|
Sure. |
I think this should be fixed. You'd like to try, or leave it to me? |
Thank you for the invitation. However, I don't have a thorough understanding of this project, and I don't want to cause any unnecessary damage or confusion. So, I would appreciate it if you could handle the issue. Thank you again for your consideration. |
|
Thanks anyway, I will note your name in next release. |
UlyssesWu
added a commit
that referenced
this pull request
Mar 26, 2023
UlyssesWu
added a commit
to Dual-Vector-Foil/FreeMote.Samples
that referenced
this pull request
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
some
.mtnfiles use strings likesrc/normal/通常|キャラ|通常来海 (結合)as its images' name, which causes an error while we are trying to export them.I add a check to
GetFriendlyNameto replace these invalid characters with_.