Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove LibVLC #491

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Remove LibVLC #491

merged 4 commits into from
Oct 25, 2024

Conversation

AnsisMalins
Copy link
Collaborator

What does this PR do?

Removes dead code associated with LibVLC. LibVLC is currently not integrated because the integration is proprietary. If/when we add LibVLC in an open source compatible way, this code can be pulled out of the history if need be.

Closes Issue(s)

None.

Motivation

Tidy.

More

None.

Additional Notes

None.

@achimmihca
Copy link
Collaborator

I am fine with removing this.
Melody Mania will continue to use libVLC, but I see why it will not work for UltraStar Play, at least as it is now.

@basisbit
Copy link
Member

Imho we should add libvlc to USPlay. Just don't use that non-free unity marketplace thing. I'll merge this MR for now to make it easier for a new fresh attempt to integrate libvlc.

@basisbit basisbit merged commit d9cd02e into master Oct 25, 2024
0 of 3 checks passed
@basisbit basisbit deleted the remove-libvlc branch October 25, 2024 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants