5.1 #44
Merged
5.1 #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Needed by the conan_toolchain.cmake in order to determine MD(d)/MT(d) in the modenr cmake-way Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
We basically did this all ready. By using the CMAKE_EXPORT_ALL_SYMBOLS instead of the generate export headers we don't need to include the generated export header file anymore Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Not used by Savitar Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Should be removed after the merge Contributes to CURA-9365
Hope this solves the missing vtable when building pySavitar on Mac Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
CURA-9365
For more uniformity, consistency and maintainability Contributes to CURA-9365
…' into CURA-9365_fix_building_cura_main
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
The Python recipe has some problems with version 2.5.1 https://github.com/conan-io/conan-center-index/blob/fff8ccc29b8d65f899bdae8df876f4d8086c17e0/recipes/cpython/all/conanfile.py#L187 Contributes to CURA-9365
Contributes to CURA-9365
https://docs.conan.io/en/1.45/versioning/revisions.html#how-it-works Contributes to CURA-9365
The ensure that the recipe hash has the same result on Widows and unix Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
This should ensure that CPython is build with default options, and that we can use it for the sipbuildtool Contributes to CURA-9365
Needed on Windows and can't hurt on other systems Contributes to CURA-9365
CPython needs to be compiled shared on Windows, but the sip wheel links against python3 Forcing the sipbuild tool to compile sip from source with: `pip install sip==6.5.1 --no-binary :all:` doesn't work and fails: `LINK : fatal error LNK1104: cannot open file 'python3.lib'` Due to time constrain leaving it to use the system python version. Since we're not linking against the system library anyway and we only use it to generate the source code from the sip files Contributes to CURA-9365
Contributes to CURA-9365
Contributes to issue CURA-9365.
Contributes to CURA-9365
Contributes to CURA-9365
41 tasks
added 2 commits
July 12, 2022 11:25
Contributes to CURA-9365
Contributes to CURA-9365
Joeydelarago
approved these changes
Jul 13, 2022
.github/workflows/conan-package.yml
Outdated
| branches: | ||
| - main | ||
| - 'CURA-*' | ||
| - '[1-9]+.[0-9]+' |
There was a problem hiding this comment.
Suggested change
| - '[1-9]+.[0-9]+' | |
| - '[0-9]+.[0-9]+' |
casperlamboo
approved these changes
Jul 13, 2022
casperlamboo
approved these changes
Jul 13, 2022
.github/workflows/conan-package.yml
Outdated
|
|
||
| jobs: | ||
| conan-recipe-version: | ||
| uses: ultimaker/cura/.github/workflows/[email protected] |
There was a problem hiding this comment.
Suggested change
| uses: ultimaker/cura/.github/workflows/conan-recipe-version.yml@5.1 | |
| uses: ultimaker/cura/.github/workflows/conan-recipe-version.yml@main |
Co-authored-by: Casper Lamboo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Ultimaker/Cura#12708 for the full overview