-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
5.1 #144
Merged
Merged
5.1 #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to CURA-9177
Contributes to CURA-9177
# Conflicts: # .github/workflows/conan-package.yml
Contributes to CURA-9177
Contributes to CURA-9177
Contributes to CURA-9177
The same once used in CuraEngine Contributes to CURA-9177
Contributes to CURA-9177
Contributes to CURA-9177
To test the clang-tidy Github Action Contributes to CURA-9177
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributes to CURA-9177
Contributes to CURA-9177
Needed to set the MSVC flags with Conan
options are specific versions or to use the same version as conan. Setting it like this assures that it is taken into account when creating the has, making sure everything links to the same version. Contributes to CURA-9177
Using the cmake_layout on Windows is giving troubles probably because it tries to be intelligent when it detects Visual Studio. Specifying the folder structure in the conanfile gives a more reliable outcome over all tree systems Contributes to CURA-9177
doing a conan install can generate these files, these should never be commited Contributes to CURA-9177
Also added section about the Python module Contributes to CURA-9177
This can cause confusion when compiling SIP
Contributes to CURA-9338
This needs to be fixed after the merge to main Contributes to CURA-9338
Contributes to CURA-9177 and CURA-9365
Contributes to CURA-9177 and CURA-9365
Contributes to CURA-9177 and CURA-9365
Contributes to CURA-9177 and CURA-9365
Contributes to CURA-9177 and CURA-9365
Contributes to CURA-9177 and CURA-9365
Contributes to CURA-9365
The Python recipe has some problems with version 2.5.1 https://github.com/conan-io/conan-center-index/blob/fff8ccc29b8d65f899bdae8df876f4d8086c17e0/recipes/cpython/all/conanfile.py#L187 Contributes to CURA-9365
Contributes to CURA-9365
https://docs.conan.io/en/1.45/versioning/revisions.html#how-it-works Contributes to CURA-9365
https://docs.conan.io/en/1.45/versioning/revisions.html#how-it-works Contributes to CURA-9365
Can only be used once merged to main Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
This should make sure that CPython builds on most systems. Which allows it to be used to configure the python module with CPython instead of the system provided one. COntributes to CURA-9365
shared. Contributes to CURA-9365
CPython needs to be compiled shared on Windows, but the sip wheel links against python3 Forcing the sipbuild tool to compile sip from source with: `pip install sip==6.5.1 --no-binary :all:` doesn't work and fails: `LINK : fatal error LNK1104: cannot open file 'python3.lib'` Due to time constrain leaving it to use the system python version. Since we're not linking against the system library anyway and we only use it to generate the source code from the sip files Contributes to CURA-9365
Contributes to CURA-9365
Contributes to issue CURA-9365.
Contributes to CURA-9365
No longer needed. Contributes to CURA-9365
Contributes to CURA-9365
41 tasks
Contributes to CURA-9365
once merged to main bump up the version in gitversion and correct this Contributes to CURA-9365
Contributes to CURA-9365
Contributes to CURA-9365
Joeydelarago
approved these changes
Jul 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update branch names
.github/workflows/conan-package.yml
Outdated
|
||
conan-package-export: | ||
needs: [ conan-recipe-version ] | ||
uses: ultimaker/cura/.github/workflows/[email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
uses: ultimaker/cura/.github/workflows/conan-recipe-export.yml@5.1 | |
uses: ultimaker/cura/.github/workflows/conan-recipe-export.yml@main |
Update branch names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Ultimaker/Cura#12708 for a detailed comment