-
Notifications
You must be signed in to change notification settings - Fork 81
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cura 9177 fix ci ct #137
Closed
Closed
Cura 9177 fix ci ct #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributes to CURA-9177
Contributes to CURA-9177
# Conflicts: # .github/workflows/conan-package.yml
Contributes to CURA-9177
Contributes to CURA-9177
Contributes to CURA-9177
The same once used in CuraEngine Contributes to CURA-9177
Contributes to CURA-9177
Contributes to CURA-9177
To test the clang-tidy Github Action Contributes to CURA-9177
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Contributes to CURA-9177
Contributes to CURA-9177
Needed to set the MSVC flags with Conan
options are specific versions or to use the same version as conan. Setting it like this assures that it is taken into account when creating the has, making sure everything links to the same version. Contributes to CURA-9177
Using the cmake_layout on Windows is giving troubles probably because it tries to be intelligent when it detects Visual Studio. Specifying the folder structure in the conanfile gives a more reliable outcome over all tree systems Contributes to CURA-9177
doing a conan install can generate these files, these should never be commited Contributes to CURA-9177
Also added section about the Python module Contributes to CURA-9177
This can cause confusion when compiling SIP
Contributes to CURA-9338
This needs to be fixed after the merge to main Contributes to CURA-9338
Contributes to CURA-9177 and CURA-9365
Contributes to CURA-9177 and CURA-9365
Contributes to CURA-9177 and CURA-9365
Contributes to CURA-9177 and CURA-9365
Contributes to CURA-9177 and CURA-9365
Contributes to CURA-9177 and CURA-9365
Contributes to CURA-9177 and CURA-9365
Contributes to CURA-9177 and CURA-9365
This ensures that a conan packages is only exported once Contributes to CURA-9177 and CURA-9365
41 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull Request should fix our failing CI/CT pipelines
In order for this to work correctly I took a bit of a head start on CURA-8830 ad CURA-8824 and CURA-8783.
We should now have a fully working pipeline, 2 to be exact, which create conan-packages and binaries (for Mac, Windows, Linux) and apply code review using our clang-tidy guidelines. This last one isn't tested yet. But will be at the next PR ;-)
The unit-testing pipeline isn't used since these repo doesn't have any.
Breakdown per workflow:
All of the above workflows are set-up in such away that the pipelines use caches to speed up setting up the VM's. We specify the Python version to use and install the required Python packages using requirements.txt This Python Version should be the same version as the one we use in our distribution, since a couple of our dependencies (such as libArcus) link against them.
In order to get semver up and running I had to retag our old 13.x up until 15.x versioning number. In order to ensure that the old tags aren't accidentally uploaded by one of our devs we have to make sure that everyone runs
git pull --prune --tags
part of:
Ultimaker/CuraEngine#1652