Add AnkerMake M5 Profile #13628
Add AnkerMake M5 Profile #13628
Conversation
|
I am new to this whole thing. How do you add this profile to Ultimaker Cura? |
@Raven-935 until this is merged in, here is a way to do this manually. https://docs.google.com/document/d/15L8_ncIyjsMVN6khWrD168GC-0MIlf46-L7oQHMzbLQ/edit#heading=h.z6ne0og04bp5 |
|
Sweet! Thanks brotha!!
…On Wed, Nov 2, 2022 at 2:14 PM just-trey ***@***.***> wrote:
I am new to this whole thing. How do you add this profile to Ultimaker
Cura?
@Raven-935 <https://github.com/Raven-935> until this is merged in, here
is a way to do this manually.
https://docs.google.com/document/d/15L8_ncIyjsMVN6khWrD168GC-0MIlf46-L7oQHMzbLQ/edit#heading=h.z6ne0og04bp5
—
Reply to this email directly, view it on GitHub
<#13628 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/A36YUVMLG7XJQDI5LKVKZWTWGJSL3ANCNFSM6AAAAAARMBTGSU>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
--
V/R,
Ken Bartells
253.651.9075
|
Joeydelarago
added
the
PR: Printer Definitions 🏭
|
(Don't worry about the 'publish test results' step, I think that's on our side.) This is looking good, but you don't have to exclude 2.85mm materials (the UltiMaker ones for example) from a machine that's for 1.75mm -- that already happens internally a step before. Also, it's usually a good idea to only put things that are actually changed between quality profiles into the quality profiles themselves. If the values are the same, you should probably just put them in the overrides for the machine (or otherwise higher up the chain). |
|
@rburema based on your feedback, I did some digging and realized a ton of stuff I have in there doesn't make it work any better. I am still testing and will be making any adjustments I need. how can I mark this as in progress, so you are not wasting your time reviewing? |
|
@just-trey There's a feature just for that: Convert it to a 'draft' pull-request. Since you don't have write access to this repo though, I do have to do the conversion. (You can make a draft PR as a normal contributor, just not convert a normal PR back to draft, even if it's your own for some reason.) It'll still show up in the list of open PR's, but the little icon will be grey instead of green, so we know it's not finished. I'm not sure if you can convert it back, so you might have to message us again to get it back to a 'normal' PR. |
|
Can you sync your fork, with our If it finds issues for which it knows a fix it should post a comment with that suggested fix such that you can easily commit that fix if you're okay with it. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "machine_start_gcode": { | ||
| "default_value": "M104 S{material_print_temperature_layer_0} ; set final nozzle temp\nM190 S{material_bed_temperature_layer_0} ; set and wait for nozzle temp to stabilize\nM109 S{material_print_temperature_layer_0} ; wait for nozzle temp to stabilize\nG28 ;Home\nG1 E10 F3600; push out retracted filament(fix for over retraction after prime)" | ||
| }, | ||
| "machine_end_gcode": { |
There was a problem hiding this comment.
Overriding machine_end_gcode with the same value (M104 S0
M140 S0
;Retract the filament
G92 E1
G1 E-1 F300
G28 X0 Y0
M84) as defined in parent definition: fdmprinter
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
|
@just-trey what do you need to mark this PR as ready for review and can we help you with that? |
|
@jellespijker I went ahead and marked as ready. I am sure it works I was just having some other folks test. Since it works let's go ahead with it and if I have future enhancements I can just make a new PR. Thanks for all the help! |
|
I see the only requested change is the spurious gcode thing. I think we can merge this. Thank you for your contribution! Devs, see internal ticket CURA-9967 to track QA processes. |
Hello. I am submitting a well-tested unofficial profile for the new AnkerMake M5 printer. Please review and let me know if there are any corrections needed.