-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show striped background when 'alternate version' enabled. #12512
Conversation
Wouldn't this have been a great use of that This seems like a bit of a heavy-handed approach, having to add a provision in all the compositing shaders. |
@fieldOfView We can still change it. (Especially since the design was just off the cuff.) What do you think @jellespijker (cc bc. involved in the nightlies) @lorenzoromagnoli (UX/UI) ? I don't think the change is that heavy compared to all the other stuff we do in the shaders (minor even), but I realize that might not be the best argument to keep adding to them. |
I discussed this with @lorenzoromagnoli and we're going to give the poor shader a rest, but (also) not involve the header any further. We'll add a yellow bar around the field instead. |
@fieldOfView I know my lack of theming is disturbing, but I also converted it to draft just now. This will all likely change anyway! |
Are you saying I'm disturbing and off-brand? :-p :-p |
How hard would it be to add the |
Not that hard, we can already somewhat easily make textures from text due to Qt (for example the 'Enterprise'/build-version tag in the splash screen is a picture), from there we'd just have to get the texture to the shader and use it there. |
See (also) backend PR.
Also shows alternate version in header bar.
(Requirement for nightly builds.)