Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show striped background when 'alternate version' enabled. #12512

Closed
wants to merge 3 commits into from

Conversation

rburema
Copy link
Member

@rburema rburema commented Jun 13, 2022

See (also) backend PR.

Also shows alternate version in header bar.

(Requirement for nightly builds.)

@fieldOfView
Copy link
Collaborator

Wouldn't this have been a great use of that backgroundPattern in the headerBackground that is still there as a placeholder?
https://github.com/Ultimaker/Cura/blob/5.0/resources/qml/Cura.qml#L196-L205

This seems like a bit of a heavy-handed approach, having to add a provision in all the compositing shaders.

@rburema
Copy link
Member Author

rburema commented Jun 14, 2022

@fieldOfView We can still change it. (Especially since the design was just off the cuff.) What do you think @jellespijker (cc bc. involved in the nightlies) @lorenzoromagnoli (UX/UI) ?

I don't think the change is that heavy compared to all the other stuff we do in the shaders (minor even), but I realize that might not be the best argument to keep adding to them.

@rburema
Copy link
Member Author

rburema commented Jun 14, 2022

I discussed this with @lorenzoromagnoli and we're going to give the poor shader a rest, but (also) not involve the header any further. We'll add a yellow bar around the field instead.

@rburema rburema marked this pull request as draft June 14, 2022 11:53
@rburema
Copy link
Member Author

rburema commented Jun 14, 2022

@fieldOfView I know my lack of theming is disturbing, but I also converted it to draft just now. This will all likely change anyway!

@lorenzoromagnoli
Copy link
Contributor

We are trying to solve 2 things:

  • clearly explain that you are running a nightly build to our users
  • Have a way to quickly identify in screenshots that the user is using a nightly build, even when taking a close-up of the UI

I made a quick mockup that I believe could solve the 2 points above without being too disturbing and off-brand.
Screen Shot 2022-06-15 at 11 36 00

@rburema
Copy link
Member Author

rburema commented Jun 15, 2022

Are you saying I'm disturbing and off-brand? :-p :-p

@lorenzoromagnoli
Copy link
Contributor

image

@jellespijker
Copy link
Member

How hard would it be to add the major.minor.patch-prerelasetag+buildmetadata as overlaid text on the build plate :-p

@rburema
Copy link
Member Author

rburema commented Jun 16, 2022

How hard would it be to add the major.minor.patch-prerelasetag+buildmetadata as overlaid text on the build plate :-p

Not that hard, we can already somewhat easily make textures from text due to Qt (for example the 'Enterprise'/build-version tag in the splash screen is a picture), from there we'd just have to get the texture to the shader and use it there.

@fieldOfView
Copy link
Collaborator

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants