make JamtisDestinationV1 serializable #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UkoeHB
requested changes
Jun 6, 2023
| @@ -71,6 +77,21 @@ struct jamtis_mock_keys | |||
| rct::key K_1_base; //jamtis spend base = k_vb X + k_m U | |||
| crypto::x25519_pubkey xK_ua; //unlock-amounts pubkey = xk_ua xG | |||
| crypto::x25519_pubkey xK_fr; //find-received pubkey = xk_fr xk_ua xG | |||
|
|
|||
| crypto::chacha_iv m_encryption_iv; | |||
There was a problem hiding this comment.
I would prefer that you implement a password-protected wrapper class instead of embedding encryption details inside the struct.
There was a problem hiding this comment.
I think you could write a template for password-protected keys.
A) static assert that the template type is POD
B) encrypt/decrypt the entire data struct as raw data (cast to void* and encrypt/decrypt in-place)
C) use RAII somehow to ensure the struct is re-encrypted as needed
D) be sure to safely handle multithreaded access to the protected container
|
Thanks for the detailed comments. I will let ghostway make the changes (if he did not do it yet) related to the key_container (jamtis_mock_keys.*) as he is working on it. So I removed this part from the PR. |
UkoeHB
requested changes
Jun 7, 2023
added 2 commits
June 7, 2023 22:00
UkoeHB
requested changes
Jun 7, 2023
Comment on lines
395
to
397
| serializable_dest_out.addr_K1 = dest.addr_K1; | ||
| serializable_dest_out.addr_K2 = dest.addr_K2; | ||
| serializable_dest_out.addr_K3 = dest.addr_K3; |
There was a problem hiding this comment.
Suggested change
| serializable_dest_out.addr_K1 = dest.addr_K1; | |
| serializable_dest_out.addr_K2 = dest.addr_K2; | |
| serializable_dest_out.addr_K3 = dest.addr_K3; | |
| serializable_dest_out.addr_K1 = dest.addr_K1; | |
| serializable_dest_out.addr_K2 = dest.addr_K2; | |
| serializable_dest_out.addr_K3 = dest.addr_K3; |
Comment on lines
696
to
698
| dest_out.addr_K1 = serializable_destination.addr_K1; | ||
| dest_out.addr_K2 = serializable_destination.addr_K2; | ||
| dest_out.addr_K3 = serializable_destination.addr_K3; |
There was a problem hiding this comment.
Suggested change
| dest_out.addr_K1 = serializable_destination.addr_K1; | |
| dest_out.addr_K2 = serializable_destination.addr_K2; | |
| dest_out.addr_K3 = serializable_destination.addr_K3; | |
| dest_out.addr_K1 = serializable_destination.addr_K1; | |
| dest_out.addr_K2 = serializable_destination.addr_K2; | |
| dest_out.addr_K3 = serializable_destination.addr_K3; |
UkoeHB
approved these changes
Jun 8, 2023
DangerousFreedom1984
added a commit
to DangerousFreedom1984/seraphis_lib
that referenced
this pull request
Jul 10, 2023
make JamtisDestinationV1 serializable --------- Co-authored-by: DangerousFreedom <[email protected]>
DangerousFreedom1984
added a commit
to DangerousFreedom1984/seraphis_lib
that referenced
this pull request
Jan 19, 2024
make JamtisDestinationV1 serializable --------- Co-authored-by: DangerousFreedom <[email protected]>
UkoeHB
pushed a commit
that referenced
this pull request
Feb 8, 2024
make JamtisDestinationV1 serializable --------- Co-authored-by: DangerousFreedom <[email protected]>
UkoeHB
pushed a commit
that referenced
this pull request
Mar 6, 2024
make JamtisDestinationV1 serializable --------- Co-authored-by: DangerousFreedom <[email protected]>
UkoeHB
pushed a commit
that referenced
this pull request
Aug 2, 2024
make JamtisDestinationV1 serializable --------- Co-authored-by: DangerousFreedom <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you please add these changes? I need to work with a serialized JamtisDestinationV1.