Configure Jitsi Meet to run behind hardware nat firewall #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
santiagomr
requested changes
Apr 11, 2020
There was a problem hiding this comment.
Nice work @fabiogermann! Thanks for sharing these improvements.
Before merging this PR, could you add the indicated spaces and update the defaults/vars in README.md with your changes?
| @@ -250,7 +250,7 @@ var config = { | |||
| // minParticipants: 2, | |||
|
|
|||
| // Use XEP-0215 to fetch STUN and TURN servers. | |||
| useStunTurn: {{ jitsi_meet_use_stun_turn }}, | |||
| useStunTurn: {{ jitsi_meet_use_stun_turn | to_json}}, | |||
There was a problem hiding this comment.
Here it would be useful add a space before closing the mustaches to make the Ansible lint happy
There was a problem hiding this comment.
I would suggest | bool | lower instead of | to_json
|
|
||
| // Use XEP-0215 to fetch STUN and TURN servers. | ||
| useStunTurn: {{ jitsi_meet_use_stun_turn }}, | ||
| useStunTurn: {{ jitsi_meet_use_stun_turn | to_json}}, |
There was a problem hiding this comment.
Here it would be useful add a space before closing the mustaches to make the Ansible lint happy
tabacha
reviewed
Apr 27, 2020
| @@ -350,10 +350,10 @@ var config = { | |||
| // through the JVB and use the peer to peer connection instead. When a | |||
| // 3rd participant joins the conference will be moved back to the JVB | |||
| // connection. | |||
| enabled: true, | |||
| enabled: {{ jitsi_meet_enable_p2p_mode | to_json }}, | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added some improvements and configuration options that are needed to set up jitsi meet behind a hardware firewall with NAT enabled.